#141680: "incorrect score display"
Mille kohta see veateade on?
Mis juhtus? Palun vali alt
Mis juhtus? Palun vali alt
Palun kontrolli, kas samal teemal on juba aruanne olemas
Kui jah, siis HÄÄLETAGE selle raporti poolt. Kõige rohkem hääli sisaldavatele aruannetele antakse PRIORITEET!
| # | Status | Votes | Game | Type | Title | Last update |
|---|
Detailne kirjeldus
-
• Kui näed ekraanil veateadet, kopeeri see siia.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kirjelda, mida sa soovisid teha, mida sa tegid ja mis juhtus
• mis on sinu veebilehitseja?
opera
-
• Palun kopeeri/kleebi kuvatud tekst inglise keeles, mitte sinu oma keeles. Kui sul on sellest veast ekraanipilt (hea tava), saad kasutada Imgur.com selle üleslaadimiseks ja lingi siia kopeerida.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kas see tekst on kättesaadav tõlkesüsteemis ? Kui jah, kas see on tõlgitud rohkem kui 24 tundi tagasi?
• mis on sinu veebilehitseja?
opera
-
• Palun selgita oma ettepanekut täpselt ja lühidalt, et oleks võimalikult lihtne mõista, mida silmas pead.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• mis on sinu veebilehitseja?
opera
-
• Mis oli ekraanil, kui sind blokeeriti? (Tühi ekraan? Osa mänguliidesest? Veateade?)
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• mis on sinu veebilehitseja?
opera
-
• Millist osa BGA kohandamisest ei järgitud
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kas reeglite rikkumist on mängu taasesitusel näha? Kui jah, siis mitmendal käigul?
• mis on sinu veebilehitseja?
opera
-
• Milline oli mängu tegevus, mida tahtsid sooritada?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Mida püüdsid teha, et seda mängu tegevust käivitada?
-
• Mis juhtus, kui seda proovisite (veateade, mängu olekuriba teade, ...)?
• mis on sinu veebilehitseja?
opera
-
• Millises mängu etapis esines probleem (Mis oli selle mänguetapi instruktsioon)?
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Mis juhtus, kui proovisite sooritada seda mängu käiku (veateade, mängu olekuriba sõnum, ...)?
• mis on sinu veebilehitseja?
opera
-
• Kirjelda kuvamise probleemi. Kui sul on sellest veast ekraanipilt (hea tava), saad kasutada Imgur.com selle üleslaadimiseks ja lingi siia kopeerida.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• mis on sinu veebilehitseja?
opera
-
• Palun kopeeri/kleebi kuvatud tekst inglise keeles, mitte sinu oma keeles. Kui sul on sellest veast ekraanipilt (hea tava), saad kasutada Imgur.com selle üleslaadimiseks ja lingi siia kopeerida.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
-
• Kas see tekst on kättesaadav tõlkesüsteemis ? Kui jah, kas see on tõlgitud rohkem kui 24 tundi tagasi?
• mis on sinu veebilehitseja?
opera
-
• Palun selgita oma ettepanekut täpselt ja lühidalt, et oleks võimalikult lihtne mõista, mida silmas pead.
it's just that for some reason there was such a bug. usually everything is fine and the actual result is correct now, but the display is incorrect
• mis on sinu veebilehitseja?
opera
Aruande ajalugu
- From the location cards image, it looks like happens in night phase.
- The left lane location number is set to `2` even though there isn't any card that modifies the number (it should be 1 in that case).
- The center lane location number is set to `3` even though `Maat` is presented (it should be 5 in that case).
Possibly there are two issues.
1. Plotting number is wrongly done in some case?
2. Day / Night state is wrongly set in some case? (while restoring game?)
1. This happened in 2nd round.
2. After browser refresh, it displayed correct result (this means the game state is restored correctly).
3. Replay from previous round did not reproduced the bug.
4. Wrongly displayed result was different from previous round result. i.e. This is not a bug that displays previous round result.
This needs further investigation.
github.com/giantroach/sunrisesunset/blob/v0.4/bga_src/backend/sunrisesunset.game.php#L1092
1. `'i18n' => ['lane'],` makes `lane` arg to be translated.
en.doc.boardgamearena.com/Translations
2. This `lane` arg is referred in client side code. And that expects one of `left`, `right` or `center`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L304
If a player is playing in other than English language (in my case Japanese), this logic won't work.
Though, it is weird that it displayed win / lose / tie on screen in this case.
1. scoreData.result is reset every `newRound`.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/sub.ts#L50
2. Displaying result logic explicitly checking the scoreData.result value without fallback.
github.com/giantroach/sunrisesunset/blob/v0.4/src/logic/state.ts#L825-L841
So I suspect this is not yet everything.
1. As I mentioned above, lane translation is one of the cause of this issue. Due to this bug, win / lose / draw is usually not be displayed when you are playing the game with other than English language.
2. When you restore the game state, score data from previous round will be restored. Current game logic is expecting to have those score data to be emptied every new round. So this is an unexpected state.
3. When score data isn't empty and when game state goes endRound, it immediately proceeds to display the game result, without waiting any other process.
4. Changing of state does not have any delay, unlike the notification handler that has max 1sec of intentional delay (to let player observe what is happening), so this causes displaying prev round score data mixed with current round data!
1. and 2. should be fixed. Do not restore the score data unless it is endRound state.
Translation of lane name is partly disabled due to this fix and currently it is inconsistent.
This translation issue will be dealt separately.
Lisa midagi sellele raportile
- Teine laua ID / käigu ID
- Kas F5 lahendas probleemi?
- Kas probleem esines mitmel korral? Igal korral?
- Kui sul on sellest veast ekraanipilt (hea tava), saad kasutada Imgur.com selle üleslaadimiseks ja lingi siia kopeerida.
